-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): fix lock file pruning optional dependencies #13830
fix(core): fix lock file pruning optional dependencies #13830
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
02c43b0
to
fca96a0
Compare
fca96a0
to
002fe77
Compare
@meeroslav as far as I understood, you have implemented this functionality, so may I ask you to have a look at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR. Please add test for npm V1 or V2 to ensure all three variants of npm lock file are working (v2 is backward compatible and contains both V1 and V3 formats).
The rest looks good to me!
Hi @meeroslav, i have added the missing lock file tests:
Let me know if i should add/change something else |
002fe77
to
092c0c0
Compare
092c0c0
to
a897734
Compare
Amazing work, @skrtheboss, thank you! |
(cherry picked from commit a2adf50)
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
Optional dependencies are omitted from the pruned .lock file.
Expected Behavior
Optional dependencies should be included in the .lock file
Related Issue(s)
Fixes #